add auxilery memory address verification #418
Conversation
|
is there a reason for this to be a power of 2? Code quote: N_SPLIT_CHUNKS |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
ohad-starkware
force-pushed
the
ohad/aux_verify
branch
from
336a3a8 to
7a68834
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @ohad-starkware)
stwo_cairo_prover/crates/prover/src/components/memory/memory_address_to_id/component.rs line 29 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
is there a reason for this to be a power of 2?
no :)
ohad-starkware
force-pushed
the
ohad/aux_verify
branch
from
7a68834 to
922c0c0
Compare
|
Suggestion: (1 << claim.memory_address_to_id.log_size) * MEMORY_ADDRESS_TO_ID_SPLIT
<= (1 << LOG_MEMORY_ADDRESS_BOUND) |
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @ohad-starkware)
stwo_cairo_prover/crates/prover/src/cairo_air/mod.rs line 135 at r2 (raw file):
assert!( 1 << claim.memory_address_to_id.log_size <= (1 << LOG_MEMORY_ADDRESS_BOUND) / MEMORY_ADDRESS_TO_ID_SPLIT
Done.
ohad-starkware
force-pushed
the
ohad/aux_verify
branch
from
922c0c0 to
45ffcdf
Compare
ohad-starkware
force-pushed
the
ohad/aux_verify
branch
from
45ffcdf to
c4387f9
Compare
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
This change is